Patch for misleading comment in src/share/vm/opto/node.cpp
Christian.Thalinger at Sun.COM
Tue Feb 24 10:46:06 PST 2009
On Tue, 2009-02-24 at 10:43 -0800, Tom Rodriguez wrote:
> On Feb 24, 2009, at 12:32 AM, Christian Thalinger wrote:
> > On Mon, 2009-02-23 at 11:15 -0800, Peter B. Kessler wrote:
> >> Peter B. Kessler wrote:
> >>> This comment is so wrong as almost to qualify as malicious.
> >>> Here's a
> >>> patch that might help.
> >>> src/share/vm/opto/node.cpp
> >>> 971 // If you modify the 'this' pointer's inputs, you must use
> >>> 'set_req' with
> >>> 972 // def-use info. If you are making a new Node (either as
> >>> the new root or
> >>> 973 // some new internal piece) you must NOT use set_req with
> >>> def-use info.
> >>> 974 // You can make a new Node with either 'new' or 'clone'.
> >>> In either case,
> >>> 975 // def-use info is (correctly) not generated.
> This piece isn't valid either. There's no separate du argument to any
> of the set functions anymore.
Remove all 5 lines?
More information about the hotspot-compiler-dev