review (XS) for 6849574: VM crash using NonBlockingHashMap (high_scale_lib)
Thomas.Rodriguez at Sun.COM
Wed Jun 10 12:13:48 PDT 2009
Oops. I thought the file looked strangely short. I'll fix it. Thanks!
On Jun 10, 2009, at 12:04 PM, Vladimir Kozlov wrote:
> Fine then.
> One more thing - you did not put copyright header into the test.
> Tom Rodriguez wrote:
>> On Jun 10, 2009, at 11:48 AM, Vladimir Kozlov wrote:
>>> In c1_LIRGenerator.cpp you changed code to do imprecise card mark
>>> on object.
>>> What happens if the object is large and the field is outside of
>>> imprecise card mark?
>> PRECISE_CARDMARK is never defined so I didn't change anything. I
>> was just removing meaningless code.
>>> Also can you explain the original comment there (could be related
>>> to the first question)?
>>> ! // Precise cardmarks don't work
>> I don't know what that comment meant. Precise cardmarks do work
>> since they are used in the other places where they are required.
>>> Tom Rodriguez wrote:
More information about the hotspot-compiler-dev