review (S) for 6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer")
Thomas.Rodriguez at Sun.COM
Tue Jun 30 14:44:56 PDT 2009
On Jun 30, 2009, at 2:33 PM, Vladimir Kozlov wrote:
> After sending this I don't see that you fixed store_oop_to_unknown.
> Is it intentional to use TypeInstPtr::BOTTOM as val_type in case of
> narrow field/element?
The value_type for the prebarrier is declared to be TypeOopPtr since
it bottoms out in LoadNode::make which always returns the wide type.
So TypeInstPtr::BOTTOM is the worst case type for the
store_oop_to_unknown case. Is there something wrong with that?
> Vladimir Kozlov wrote:
>> Looks good.
>> Tom Rodriguez wrote:
More information about the hotspot-compiler-dev