Request for review (L): 6797305: Add LoadUB and LoadUI opcode class
Christian.Thalinger at Sun.COM
Mon Mar 2 02:30:15 PST 2009
On Fri, 2009-02-27 at 14:58 -0800, Tom Rodriguez wrote:
> I've added some more parsing lookahead to deal with this case properly
> and updated the address webrev to include it. $mem$$base$$Register
> and $mem$$index$$Register should now emit properly.
Works great, thanks! Now there are only two small things left:
- Something like $dst$$Register$high or $dst$$HighRegister for x86_32,
so the long HIGH_FROM_LOW macro can be omitted. The same for $low would
also be nice, just to make it more obvious.
- Similar to the one above for $mem, e.g. $mem$$Address$high, for long
memory accesses. Currently I'm using:
Address Amemlo = Address::make_raw($mem$$base, $mem$$index, $mem$$scale, $mem$$disp, false);
Address Amemhi = Address::make_raw($mem$$base, $mem$$index, $mem$$scale, $mem$$disp + 4, false);
__ movl($dst$$Register, Amemlo);
__ movl(HIGH_FROM_LOW($dst$$Register), Amemhi);
I can try to add that functionality, but I wanted to ask if there is
already something like that?
More information about the hotspot-compiler-dev