for (re-)review (M): 6814659: separable cleanups and subroutines for 6655638
Vladimir.Kozlov at Sun.COM
Mon Mar 9 08:24:08 PDT 2009
something wrong with this webrev, diffs are reversed
for example, in stubGenerator_sparc.cpp.
And assembler_sparc.hpp, c1_LIRAssembler_sparc.cpp don't have diffs.
John Rose wrote:
> In order to reduce the size of my forthcoming method handles changeset,
> I have (at Vladimir's suggestion) pulled out chunks of independent
> changes this week. The four chunks amount to about 40% of the changes,
> and are more easily tested and reviewed in isolation.
> The fourth chunk 6814659 is the most miscellaneous. It is a bunch of
> changes that were necessary either for debugging method handles, or for
> supporting them. They can all be considered independently.
> Here are the changes:
> Not much review is necessary here, because these changes have already
> been reviewed as part of the larger changeset.
> The current draft of the big change is here:
> -- John
> P.S. For the record, here is the sequence:
> 1. 6812678: macro assembler needs delayed binding of a few constants
> (for 6655638)
> 2. 6812831: factor duplicated assembly code for megamorphic
> invokeinterface (for 6655638)
> 3. 6812831 factor general subclass check (for 6655638)
> http://cr.openjdk.java.net/~jrose/6813212/webrev.01/ (not yet integrated)
> 4. 6814659: separable cleanups and subroutines for 6655638
> http://cr.openjdk.java.net/~jrose/6814659/webrev.00/ (not yet integrated)
> 5. 6655638: dynamic languages need method handles
> http://cr.openjdk.java.net/~jrose/6655638/webrev.00/ (not yet integrated)
> And here are the patch file sizes (from my mq patch queue):
> 1178 5493 48571 asm-6812678.patch
> 979 5029 40958 ilookup-6812831.patch
> 1611 7834 70518 subtype-6813212.patch
> 1147 4962 48089 minor-6814659.patch
> 7274 33505 311948 meth.patch
> 12189 56823 520084 total
More information about the hotspot-compiler-dev