Request for reviews (XS): 6890984: Comparison of 2 arrays could cause VM crash
Thomas.Rodriguez at Sun.COM
Wed Oct 14 14:46:43 PDT 2009
That looks good.
On Oct 14, 2009, at 2:14 PM, Vladimir Kozlov wrote:
> Fixed 6890984: Comparison of 2 arrays could cause VM crash
> I did incorrect "optimization" in 6827605 changes -
> replaced 2 null pointer checks with andptr(p1,p2)
> instruction which damages the result register.
> I should have use testptr(p1,p2) but it is also incorrect.
> There is problem on sparc also - br() instruction is used
> instead of brx() when comparing pointers.
> Restore original null checks for x86.
> Use brx() when comparing pointers on sparc.
> Reviewed by:
> Fix verified (y/n): y, bug's test on both platforms with 32- and 64-
> bit VM
> Other testing:
More information about the hotspot-compiler-dev