Request for reviews (L): 6939207: refactor constant pool index processing

Christian Thalinger Christian.Thalinger at Sun.COM
Wed Apr 7 02:16:35 PDT 2010

On Tue, 2010-04-06 at 02:00 -0700, John Rose wrote:
> I have completed this change by centralizing the byte-swapping logic for bytecode instruction operands.
> Here is the updated webrev:

src/cpu/x86/vm/templateTable_x86_32.cpp, src/cpu/x86/vm/templateTable_x86_64.cpp:

2119     // This kind of CP cache entry does not need t match the byte, because


2190                                                bool is_invokevfinal, /*unused*/

I guess the /*unused*/ is for is_invokevfinal, so the "," should be
after the comment.


   int get_index_giant() const {
-    assert_index_size(4);
+    assert_index_size(4); assert_native_index();
     return Bytes::get_native_u4(_bc_start+1);

Should we assert on has_giant_index in this one?


+                                      size_t index_size); // one of 1,2,4

What do you think about using enum values instead of sizeof(u?) in the

And there are a couple of copyright year updates missing.  Otherwise
looks good and I like the change.

-- Christian

More information about the hotspot-compiler-dev mailing list