Request for reviews (XL): 6919934: JSR 292 needs to support x86 C1
Christian.Thalinger at Sun.COM
Thu Apr 8 01:33:55 PDT 2010
On Wed, 2010-04-07 at 12:15 -0700, Tom Rodriguez wrote:
> On Apr 2, 2010, at 4:01 PM, Christian Wimmer wrote:
> >> http://cr.openjdk.java.net/~never/6939930 is a full solution.
> >> 6939930: exception unwind changes in 6919934 hurts compilation speed
> >> Reviewed-by:
> > I think that is a good unified solution now, and works in my workspace. I have two small comments:
> > * LIRAssembler_sparc.cpp: There is no "stub->emit_code(this);" like in the x86 code
> Thanks for catching that.
> > * LIR.hpp: lir_unwind can now be a LIR_Op1. In LIR.cpp you assert that the second operand of the current LIR_Op2 is never used, which is weird.
> Yeah, I wimped out on the that. I've fixed that and updated the webrev.
2123 __ br(Assembler::always, false, Assembler::pn, _unwind_handler_entry);
Why do you use Assembler::pn for this branch? Wouldn't a __ ba(...) be
the right instruction here?
Otherwise looks good.
More information about the hotspot-compiler-dev