Request for reviews (XL): 6919934: JSR 292 needs to support x86 C1
tom.rodriguez at oracle.com
Thu Apr 8 09:47:48 PDT 2010
On Apr 8, 2010, at 1:33 AM, Christian Thalinger wrote:
> On Wed, 2010-04-07 at 12:15 -0700, Tom Rodriguez wrote:
>> On Apr 2, 2010, at 4:01 PM, Christian Wimmer wrote:
>>>> http://cr.openjdk.java.net/~never/6939930 is a full solution.
>>>> 6939930: exception unwind changes in 6919934 hurts compilation speed
>>> I think that is a good unified solution now, and works in my workspace. I have two small comments:
>>> * LIRAssembler_sparc.cpp: There is no "stub->emit_code(this);" like in the x86 code
>> Thanks for catching that.
>>> * LIR.hpp: lir_unwind can now be a LIR_Op1. In LIR.cpp you assert that the second operand of the current LIR_Op2 is never used, which is weird.
>> Yeah, I wimped out on the that. I've fixed that and updated the webrev.
> 2123 __ br(Assembler::always, false, Assembler::pn, _unwind_handler_entry);
> Why do you use Assembler::pn for this branch? Wouldn't a __ ba(...) be
> the right instruction here?
It's a copy paste from somewhere else. I don't think it really matters but I fixed that one and the place I copied it from. I've updated the webrev. Thanks!
> Otherwise looks good.
> -- Christian
More information about the hotspot-compiler-dev