Request for reviews (M): 6930772: JSR 292 needs to support SPARC C1
tom.rodriguez at oracle.com
Thu Apr 15 10:31:56 PDT 2010
Could the is_method_handle_invoke become part of CodeEmitInfo instead? That would make more sense to me.
On Apr 15, 2010, at 4:25 AM, Christian Thalinger wrote:
> On Fri, 2010-04-09 at 11:06 -0700, Tom Rodriguez wrote:
>> I don't like the way this is structured. Why not move the
>> preserve/restore SP logic up into the LIR as regular moves? Then you
>> don't need any of this special handling. In fact the delay slot
>> filling will likely move the preserve SP logic into the delay slot as
>> you would like it to be.
> You're right. Here is a new webrev:
> I'm not sure if the LIR_OpDelay::is_method_handle_invoke is good name
> Additionally I changed ciMethod::is_method_handle_invoke to use the
> holder and method name to be able to call it on unloaded methods. John
> hasn't replied yet on my email if that's OK but my extensive testings
> show that it should be OK.
> -- Christian
More information about the hotspot-compiler-dev