Request for reviews (XL): 6829193: JSR 292 needs to support SPARC
Christian.Thalinger at Sun.COM
Fri Apr 23 05:16:24 PDT 2010
On Wed, 2010-04-21 at 18:14 -0700, John Rose wrote:
> Although I like the way the code reads, the side-effect to &offset is
> a little unnerving when you look into the details. I could live with
> reformulating the regcon_foo_ptr macros to return the new
> RegisterOrConstant value as an explicit result, rather than patching
> it in-place as the dest argument.
I changed that. But it still feels a little odd and sometimes difficult
that the macro works as:
RegisterOrConstant regcon_sll_ptr(RegisterOrConstant dest, RegisterOrConstant src, Register temp = noreg);
I'd actually like it more this way:
void regcon_sll_ptr(RegisterOrConstant s1, RegisterOrConstant s2, RegisterOrConstant d);
> But I think regcon_sll_ptr_by_con should go.
More information about the hotspot-compiler-dev