Request for reviews (XL): 6829193: JSR 292 needs to support SPARC

Christian Thalinger Christian.Thalinger at Sun.COM
Fri Apr 23 03:50:29 PDT 2010

On Wed, 2010-04-21 at 12:32 -0700, John Rose wrote:
> > The switch in load_sized_value is too clever for my taste.  How
> about just a switch on size_in_bytes with a test on is_signed where
> it's needed?
> My high school writing teacher used to direct us, if we thought we had
> written something especially clever, to be ready to strike it out.
> Christian, if you break up the Overly Clever Switch in the sensible
> way Tom suggests, please break up the parallel one in the x86 code
> too.

I changed in both places.  -- Christian

More information about the hotspot-compiler-dev mailing list