Request for reviews (M): 6930772: JSR 292 needs to support SPARC C1

Christian Thalinger Christian.Thalinger at Sun.COM
Wed Apr 28 05:35:55 PDT 2010

On Wed, 2010-04-28 at 13:22 +0200, Christian Thalinger wrote:
> > I think is_method_handle_invoke should be true only for the
> > signature-polymorphic members of java.dyn.MethodHandle (invoke,
> > eventually invokeGeneric/invokeExact).  We should have a different
> > predicate (if we need it) for adapters.
> Well, I think we need it, otherwise we don't inline them (from
> InlineTree::shouldNotInline):
>   // Always inline MethodHandle methods.
>   if (callee_method->is_method_handle_invoke())
>     return NULL;
> Wait!  We have methodOopDesc::is_method_handle_adapter.  I think we
> should add a check for that in the above statement and only return true
> in ciMethod::is_method_handle_invoke as you suggested above.

That doesn't work.  I forgot that generated adapters for MH call sites
are called java.dyn.MethodHandle::invoke and that fits the pattern of
ciMethod::is_method_handle_invoke.  We need something else...

-- Christian

More information about the hotspot-compiler-dev mailing list