Review Request: Zero JNI handles fix

Christian Thalinger Christian.Thalinger at Sun.COM
Fri Apr 30 04:28:49 PDT 2010

On Thu, 2010-04-22 at 12:14 +0100, Gary Benson wrote:
> > I've reworked the fix:
> > 
> >
> > 
> > last_Java_sp() now returns the actual Zero stack pointer.  The frame
> > anchor has a new last_Java_fp field that stores the value previously
> > stored in last_Java_sp, in much the same way as the x86 port does.
> > 
> > Note that the code in frame_zero.* already stored both these values,
> > but with the names confusingly reversed.  I have unreversed them in
> > this webrev.  I have also changed the type of the frame pointer be a
> > ZeroFrame* -- leaving the stack pointer as an intptr_t* -- to help
> > ensure that everything gets the arguments in the right order.
> A minor update:

I assume the changes work as you have (hopefully) tested them.  Since it
only touches Zero files, I'd say the changes are OK.  I will push it.

I also add Keith as reviewer.

-- Christian

More information about the hotspot-compiler-dev mailing list