'ciConstant' and 'ciField' unnecessarily declare 'print_impl()' method
tom.rodriguez at oracle.com
Fri Dec 10 10:29:56 PST 2010
On Dec 10, 2010, at 10:05 AM, Volker Simonis wrote:
> Well, I found 58 occurences of "#if 0".
> I don't want to say that they are all useless, but probably very few
> people remember what they are good for:)
A lot of it appears to be saved debug or printing code which seems like a reasonable use of #if 0.
> Have you considered them for removal?
I think I'd leave most of them alone. There are a couple that look deletable though. I'll take a look.
> On Fri, Dec 10, 2010 at 6:46 PM, Tom Rodriguez <tom.rodriguez at oracle.com> wrote:
>> On Dec 10, 2010, at 6:44 AM, Volker Simonis wrote:
>>> while debugging I just realized that the two classes 'ciConstant' and
>>> 'ciField' unnecessarily declare a 'print_impl()' method which is never
>>> defined nor called. They have probably been declared there because the
>>> two class names suggest that the classes are derived from 'ciObject'
>>> but that's not the case.
>>> To avoid further confusion I'd suggest to simply remove the two
>>> declarations. If somebody will open a bug I'll volunteer to submit the
>>> But perhaps it's easier to remove the two useless declarations as part
>>> of another change to save bug IDs:)
>> I've been accumulating some dead code changes so I'll add these to it. Any other dead things or thing that you suspect are dead?
More information about the hotspot-compiler-dev