review (S) for 6909839: missing unsigned compare cases for some cmoves in sparc.ad
Thomas.Rodriguez at Sun.COM
Wed Jan 6 14:10:30 PST 2010
On Jan 6, 2010, at 12:54 PM, John Rose wrote:
> On Jan 6, 2010, at 12:26 PM, Tom Rodriguez wrote:
> Looks good. You might consider changing the pre-existing cmovII_U to cmovIIu for consistency.
> Also, did you intend to omit cmovNIu? Your test case (or similar cases) could possibly fail in compressed oops VMs.
Good catch. Not sure why I forgot that. I'll add that and retest.
> -- John
More information about the hotspot-compiler-dev