Request for reviews (S): 6959430: Make sure raw loads have control edge
Christian.Thalinger at Sun.COM
Wed Jun 9 02:09:28 PDT 2010
On Tue, 2010-06-08 at 19:12 -0700, Vladimir Kozlov wrote:
> I will push it after 6953058 fix is pulled into our repository.
> Fixed 6959430: Make sure raw loads have control edge
> Safepoint polls don't produce a new raw memory state
> so loads of raw are allowed to float above safepoint
> during which a raw value could be modified.
> Note, I added two checks. One is in factory methods
> so the call stack will show where it is called from.
> An other is in final graph reshape code to catch
> nodes for which constructors were used directly.
> Passed CTW and JPRT.
In GraphKit::shared_lock you could call GraphKit::increment_counter
instead of having duplicate code.
More information about the hotspot-compiler-dev