Review Request: Shark
Christian.Thalinger at Sun.COM
Tue Jun 22 01:35:25 PDT 2010
On Fri, 2010-06-11 at 15:16 +0100, Gary Benson wrote:
> Hi all,
> Shark is a JIT compiler for Zero that uses the LLVM compiler
> infrastructure to compile Java methods without introducing
> system-specific code. This webrev adds Shark support to
I only looked at the HotSpot changes since I have no idea about the
Shark stuff. Everything looks pretty good factored with #ifdefs.
+ SharkEntry* entry = (SharkEntry *) nm->instructions_begin();
+ unsigned char* p = entry->code_start();
+ unsigned char* end = entry->code_limit();
Why do you need to stuff a SharkEntry into the address?
assert(CodeCache::find_blob_unsafe(frame_pcs) != NULL, "bad pc");
+#endif // SHARK
Why does this assert not hold?
Still has the old Sun copyright header.
More information about the hotspot-compiler-dev