Request for reviews (XXL): 6961690: load oops from constant table on SPARC
christian.thalinger at oracle.com
Tue Nov 30 07:55:42 PST 2010
On Nov 25, 2010, at 4:57 PM, Christian Thalinger wrote:
>> I don't understand how MachConstantBaseNode::size() is not called
>> on sparc where there is code generated for it? You need the size.
>> It seems, you have to calculate it manually.
> SPARC does not use Compile::Shorten_branches and that's the only place where I got calls to size.
I implemented MachConstantBaseNode::size on SPARC too.
>> I think you don't need to add_req() in constructor and then use
>> set_req(root) since new MachConstantBase node is only created in
>> Compile::mach_constant_base_node() so you can add_req(root) there
> I will send out a review later or tomorrow.
I removed the additional pipe_class'es on SPARC again. That should be the final version.
More information about the hotspot-compiler-dev