Review Request: Zero JSR 292 support
christian.thalinger at oracle.com
Tue Apr 5 05:46:23 PDT 2011
On Apr 1, 2011, at 4:33 PM, Gary Benson wrote:
> Hi all,
> This webrev adds support for JSR 292 to Zero:
+ // NB the x86 code for this (in methodHandles_x86.cpp, search for
+ // "genericInvoker") is really really odd. I'm hoping it's trying
+ // to accomodate odd VM/class library combinations I can ignore.
Do you mean the code around sorry_no_invoke_generic?
+ assert(false, "Should have thrown incompatible class change exception");
I'd use ShouldNotReachHere instead.
I have to say that I don't know very much about the C++ interpreter or Zero but the code looks good. Most important is that the MethodHandlesTest passes.
> Note that is is designed to apply after the fix for 7032458,
> which is currently under review and can be found here:
> I don't have a bug id for this.
More information about the hotspot-compiler-dev