Request for review (S): 7018355: JSR 292: VM crash in DefNewGeneration::copy_to_survivor_space
vladimir.kozlov at oracle.com
Fri Apr 15 08:42:06 PDT 2011
Christian Thalinger wrote:
> John suggested:
> "Consider changing return-by-reference of klassOop to rbr of a handle. Avoid the scoped oop temp."
> So I changed MethodHandles::decode_* function to take a KlassHandle and return a methodHandle instead of oops which makes the uses of these methods simpler.
> webrev udpated.
> -- Christian
> On Apr 13, 2011, at 11:11 PM, Christian Thalinger wrote:
>> On Apr 13, 2011, at 9:01 PM, Vladimir Kozlov wrote:
>>> Looks good.
>> Thanks, Vladimir. -- Christian
>>> Christian Thalinger wrote:
>>>> 7018355: JSR 292: VM crash in DefNewGeneration::copy_to_survivor_space
>>>> There are a couple of unhandled oop usages over potential safepoints
>>>> in methodHandles.cpp. Three of them could be found with
>>>> +CheckUnhandledOops, the other ones were either found via
>>>> visual-inspection or just were changed for the sake of safety.
More information about the hotspot-compiler-dev