Request for reviews (S): 7077439: Possible reference through NULL in loopPredicate.cpp:726
vladimir.kozlov at oracle.com
Wed Aug 10 14:01:03 PDT 2011
Thank you, Tom
Tom Rodriguez wrote:
> Looks good.
> On Aug 10, 2011, at 12:47 PM, Vladimir Kozlov wrote:
>> Fixed 7077439: Possible reference through NULL in loopPredicate.cpp:726
>> VM crashed at the next line because cl->loopexit() == NULL when I tried to port 7070134 into previous Hotspot sources:
>> BoolTest::mask bt = cl->loopexit()->test_trip();
>> I did not see such crush with latest HS22 sources but it does not mean it can't happen. The check cl->is_valid_counted_loop() should be used in the code to avoid such crush. Note, this check is superset of cl->stride_is_con() so the later could be replaced.
More information about the hotspot-compiler-dev