Request for review (S): 7022998: JSR 292 recursive method handle calls inline themselves infinitely
vladimir.kozlov at oracle.com
Tue Mar 15 09:57:40 PDT 2011
Instead of duplicating code in several places could you factor it in one method?
sharedRuntime.cpp: you removed "---" which was indication of native method
Main fix is fine.
Christian Thalinger wrote:
> 7022998: JSR 292 recursive method handle calls inline themselves infinitely
> Methods doing recursive method handle calls, like in JRuby's
> bench_fib_resursive.rb or bench_tak.rb, inline themselves infinitely.
> This results in a huge method which hits compile thresholds and aborts
> inlining resulting in poor performance.
> The inlining logic needs to know about method handle call sites and
> search the call stack for recursive calls.
> This change also cleans up the PrintCompilation, PrintInlining and
> TraceTypeProfile output to be aligned since the tiered compilation
> changes added some additional output.
More information about the hotspot-compiler-dev