Review Request: Zero and Shark fixes
gbenson at redhat.com
Wed Mar 30 05:45:37 PDT 2011
Dr Andrew John Hughes wrote:
> On 30 March 2011 11:52, Gary Benson <gbenson at redhat.com> wrote:
> > This webrev contains a bunch of fixes for Zero and Shark:
> > http://cr.openjdk.java.net/~gbenson/zero-shark-fixes-04/
> > Firstly, changes to tiered compilation required fixes to allow
> > Shark to build.
> This change was added to IcedTea6 prior to 1.10 as the bug is
> present in hs20. I'm surprised you've only just hit it.
I'm not 100% sure which individual changeset broke things, so
I can't say. Maybe nobody built Shark for a while?
> > Secondly, my fix for 7030207 uncovered a bug in the C++
> > interpreter where finalizers were not being registered.
> > I can split the webrev into two if you'd like.
> There seem to also be copyright changes here too...
Yes, I updated the copyright years on the files I changed.
> ...and the STDC_LIMIT_MACROS also in IcedTea.
Why wasn't it upstreamed?
More information about the hotspot-compiler-dev