Review Request: Zero and Shark fixes
Dr Andrew John Hughes
gnu_andrew at member.fsf.org
Wed Mar 30 07:28:57 PDT 2011
On 30 March 2011 13:45, Gary Benson <gbenson at redhat.com> wrote:
> Dr Andrew John Hughes wrote:
>> On 30 March 2011 11:52, Gary Benson <gbenson at redhat.com> wrote:
>> > This webrev contains a bunch of fixes for Zero and Shark:
>> > http://cr.openjdk.java.net/~gbenson/zero-shark-fixes-04/
>> > Firstly, changes to tiered compilation required fixes to allow
>> > Shark to build.
>> This change was added to IcedTea6 prior to 1.10 as the bug is
>> present in hs20. I'm surprised you've only just hit it.
> I'm not 100% sure which individual changeset broke things, so
> I can't say. Maybe nobody built Shark for a while?
We hit it as soon as the hs20 stable tree became available and was
used in IcedTea6.
I mentioned it to you on IRC at the time, but you showed no intention
of fixing it. So I ended up doing it.
I thought you were working directly on OpenJDK7 now and thus would
have caught it much earlier.
The changeset is:
date: Tue Nov 23 13:22:55 2010 -0800
summary: 6989984: Use standard include model for Hospot
and it's a simple mistake. This line:
+CORE_PATHS := $(shell find $(GAMMADIR)/src/share/vm/* -type d \! \(
-name adlc -o -name c1 -o -name gc_implementation -o -name opto -o
-name shark -o -name libadt \))
filters shark material out of CORE_PATHS, but none of the lines below
add it back in. So the files are never compiled.
>> > Secondly, my fix for 7030207 uncovered a bug in the C++
>> > interpreter where finalizers were not being registered.
>> > I can split the webrev into two if you'd like.
>> There seem to also be copyright changes here too...
> Yes, I updated the copyright years on the files I changed.
Ok, I thought there were some files with only copyright changes but,
on second reading, there does appear to be single line code changes
>> ...and the STDC_LIMIT_MACROS also in IcedTea.
> Why wasn't it upstreamed?
Both were on my list to do, but I don't have infinite time. IcedTea6
takes priority over OpenJDK7 which won't be released for at least
another six months.
That's not to mean that no-one else could have upstreamed the changes.
I seem to be pretty much the only person who bothers to most of the
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
PGP Key: F5862A37 (https://keys.indymedia.org/)
Fingerprint = EA30 D855 D50F 90CD F54D 0698 0713 C3ED F586 2A37
More information about the hotspot-compiler-dev