review for 7043040: JSR292: JRuby bench/shootout/binarytrees.ruby-2.ruby SEGV: constantPoolKlass::oop_follow_contents
tom.rodriguez at oracle.com
Tue May 10 16:23:18 PDT 2011
Thanks Vladimir and Ramki.
On May 10, 2011, at 2:38 PM, Y. S. Ramakrishna wrote:
> looks good.
> -- ramki
> On 05/10/11 13:21, Tom Rodriguez wrote:
>> 7043040: JSR292: JRuby bench/shootout/binarytrees.ruby-2.ruby SEGV: constantPoolKlass::oop_follow_contents
>> The logic in oop_push_constants was skipping JVM_CONSTANT_Object
>> entries which would cause corruption in later GCs. The fix is to use
>> is_pointer_entry to identify roots like all the other visitor. The
>> verify_on method was also too weak so it missed the problem when run
>> with the verify GC flags. Tested with failing test from report.
More information about the hotspot-compiler-dev