review(S): 7112085: assert(fr.interpreter_frame_expression_stack_size()==0) failed: only handle empty stacks

Vladimir Kozlov vladimir.kozlov at
Wed Nov 16 15:19:09 PST 2011

Thank you, Igor


Igor Veresov wrote:
> On Wednesday, November 16, 2011 at 12:46 PM, Vladimir Kozlov wrote:
>> Looks good.
> Thank you. 
>> Did it pass all compiler regression tests with -XX:+TieredCompilation
>> -XX:+DeoptimizeALot?
> Yes. I just reran the tests again to make sure. I also noticed a problem 
> with the test for 6792161. It increases the inlining size so much that 
> it makes the fastdebug C1 very slow. I'll have to investigate why, but 
> for now I decide to increase the timeout. Webrev updated.
> igor
>> Thanks,
>> Vladimir
>> Igor Veresov wrote:
>>> The runtime call to the policy from the inlinee invocation had an
>>> incorrect jvm state. As a result the bytecode preceding the invoke of
>>> the inlinee was executed twice in case we deoptimized. Since it's
>>> currently not quite easy to set the reexecute flag in C1, I moved the
>>> notification call into the preamble of the inlinee so that I could use
>>> InvocationEntryBci in the state specification, which would deopt 
>>> correctly.
>>> Also made some minor changes to printing of tiered events.
>>> Webrev:
>>> Thanks!
>>> igor

More information about the hotspot-compiler-dev mailing list