RFR(S): 8003983 Fix of broken logcompilation tool
john.r.rose at oracle.com
Tue Dec 4 12:37:14 PST 2012
On Nov 26, 2012, at 7:04 AM, Nils Eliasson wrote:
> Fixing LogCompilation tool so that I can do my own additions later.
> Includes fixes for:
> c1 missing parse tag that is required to surround method tag
> c1 call tag requires count attribute
> c1 phase tag requires nodes (set to zero since there is no nodes concept in c1)
> Method tag must handle missing bytes, iicount and flags attributes when unloading=1 is set
> Wrong description in help for '-n'.
> Tested with running HelloDate on tiered with -Xcomp. Will add this as jtreg test separately.
> Nils Eliasson
Generally speaking, if an attribute in the LogCompilation XML has a default value, it can be omitted from the log file. At least, that's how I think about the XML schema (or lack thereof).
Therefore, I think the XML reader needs to be robust if attributes are missing.
You are adding these explicit attributes to some parts of the XML output:
phase ... nodes='0'
parse_done ... nodes='0'
call ... count='0'
This is OK, but would it be possible to default them in the reader instead? That way of doing things may lead to a more robust system. Something like this:
- site.setCount(Integer.parseInt(search(atts, "count")));
+ site.setCount(Integer.parseInt(search(atts, "count", "0")));
In the present case, either way is fine with me. You can cite me as a reviewer.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev