RFR(L): 8005071: Incremental inlining for JSR 292

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu Dec 20 15:40:54 PST 2012

This is better.

MaxNodeLimit value setting logic should be reversed: default is 65000 
(as before) and if IncrementalInline is true set to 110000.


We draw subgraph in comments vertically, not horizontally.

has_unique_phi() does the same as your first part of try_clean_mem_phi().

Also use phi->as_Phi()->is_diamond_phi() instead of region's inputs checks.

Don't use second loop, you only have 2 inputs to check so use in(3-i).


string_inline() - no need empty separating lines in while() loop.
incremental_inline_one() - remove outer "{}", I don't see the need for 
them. No need empty separating lines in first loop.


On 12/20/12 12:24 PM, Vladimir Kozlov wrote:
> Roland,
> you sent link to wrong webrev. Is this correct one?:
> http://cr.openjdk.java.net/~roland/8005071/webrev.01/
> I'm looking on it now.
> Thanks,
> Vladimir
> On 12/20/12 11:34 AM, Roland Westrelin wrote:
>> Here is a new webrev:
>> http://cr.openjdk.java.net/~roland/8005031/webrev.01/
>> - I dropped the special purpose dead code elimination, made stricter
>> checks of inputs when inlining incrementally, and now do one igvn for
>> every successful inlining
>> - I made a couple fixes to PhaseStringOpts so it works ok when it
>> happens after all inlining
>> - I took all suggestions that Vladimir and Christian made into account
>> Roland.

More information about the hotspot-compiler-dev mailing list