review request (S): 7126041: jdk7u4 b05 and b06 crash with RubyMine 3.2.4, works well with b04
igor.veresov at oracle.com
Mon Feb 13 19:26:22 PST 2012
I'm actually fine either way, it's not that important. To me a private method of a class is more local than a module-wide declaration.
On Monday, February 13, 2012 at 12:04 PM, Roland Westrelin wrote:
> > A comment on the is_safepoint function would be helpful. Otherwise it looks good.
> Thanks. I'll add a comment.
> Do you agree with Igor that the function should be a method of Canonicalizer. I think it's fine as a local utility function.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev