Request for reviews (XS): 7123926: Some CTW test crash: !_control.contains(ctrl)
rednaxelafx at gmail.com
Mon Jul 9 00:49:52 PDT 2012
On Fri, Jul 6, 2012 at 11:34 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com
> > I'm a little bit worried about this part after seeing your fix for
> 7181658. Do you think it's safe to use uncast()
> It was another Vladimir (Ivanov) who fixed 7181658 :-)
> Oops, I'm sorry guys!
> > this way, or should we use eqv_uncast() for comparison at the use sites
> of StringConcat::argument_uncast(**)?
> I think using uncast() in argument_uncast() is safe, it is used only in
> related code. The first time argument_uncast() is called to find a Proj
> node from SB.toString() call. Then that Proj node passed to merge() method
> as 'arg'. And in the merge() method argument_uncast() is called second time
> to compare with that passed 'arg'.
> Alright. I just needed someone else to confirm it.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-compiler-dev