RFR (S): 8010090 - GC ID has the wrong type

云达(Yunda) yunda.mly at taobao.com
Wed Apr 17 20:48:16 PDT 2013


I think the GC part looks good. But I found the value put into Compile ID is actually int, not uint(share/vm/opto/compile.hpp):
470   int               compile_id() const          { return _compile_id; }
Are you sure it is non-negative?


> -----Original Message-----
> From: hotspot-gc-dev-bounces at openjdk.java.net
> [mailto:hotspot-gc-dev-bounces at openjdk.java.net] On Behalf Of Jesper
> Wilhelmsson
> Sent: Tuesday, April 16, 2013 10:17 PM
> To: hotspot-gc-dev openjdk.java.net; hotspot-compiler-dev at openjdk.java.net
> Subject: RFR (S): 8010090 - GC ID has the wrong type
> Hi,
> Could I have a couple of reviews for this really small change.
> The type of the GC ID and the Compile ID in the different tracing events should
> be UINT as the values put into these fields are uint.
> Webrev: http://cr.openjdk.java.net/~jwilhelm/8010090/webrev/
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010090
> Thanks,
> /Jesper


This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you.


More information about the hotspot-compiler-dev mailing list