RFR(XS): 8024008: Nashorn V8 (Crypto) benchmark crashes with small CodeCache size

Vladimir Kozlov vladimir.kozlov at oracle.com
Mon Sep 9 10:47:48 PDT 2013

Several places in sources do not check returned result of make_not_entrant_or_zombie(). And they may assume that method 
marked as non-entrant, for example, because before we returned 'false' only when an other thread already changed the 
state to one we need.

Can you check all call sites to make sure they work correctly with this change?


On 9/9/13 6:59 AM, Albert Noll wrote:
> Hi,
> thanks for reviewing this patch.
> https://bugs.openjdk.java.net/browse/JDK-8024008
> http://cr.openjdk.java.net/~anoll/8024008/webrev.00/ <http://cr.openjdk.java.net/%7Eanoll/8024008/webrev.00/>
> Many thanks in advance,
> Albert
> Problem:
> The state of nmethods that are currently locked by the VM must not change.
> Some operations such as setting ICs (e.g., SharedRuntime::resolve_sub_helper())
> rely on this fact.  'nmethod::make_not_entrant_or_zombie does not make this
> check.
> Solution:
> Do method state unchanged of nmethod is locked by the VM.
> Testing: Run Octane benchmarks on top of Nashorn with small code cache size (16m).

More information about the hotspot-compiler-dev mailing list