RFR(XS) 8024917: Remove public pointer to PhaseLive in PhaseChaitin

Vladimir Kozlov vladimir.kozlov at oracle.com
Tue Sep 17 10:02:46 PDT 2013

In general it is fine but I don't like your change to dump() methods.
dump() methods are used during debugging (I used them). Adding 
parameters to them complicates that. Before I could call dump() or 
dump(b) to get info in debugger. Now I have to pass additional argument 
and remember what its local name. Please, find solution to not change 
dump() methods.
And don't remove dump_bb().


On 9/17/13 1:58 AM, Niclas Adlertz wrote:
> Hi all,
> Removing a public pointer to PhaseLive which can be accessed at any time
> from PhaseChaitin, instead passing a reference of the PhaseLive instance
> to the methods that use it.
> A review would be much appreciated.
> WEBREV: http://cr.openjdk.java.net/~adlertz/JDK-8024917/webrev00
> JBS: https://bugs.openjdk.java.net/browse/JDK-8024917
> Kind Regards,
> Niclas Adlertz

More information about the hotspot-compiler-dev mailing list