RFR (XS): 8028037: "[parfait] warnings from b114 for hotspot.src.share.vm "
vladimir.kozlov at oracle.com
Fri Mar 7 19:45:20 UTC 2014
On 3/7/14 11:38 AM, David Chase wrote:
> It's a trivial change, but I'm rerunning jtreg anyhow:
> new fix: http://cr.openjdk.java.net/~drchase/8028037/webrev.01/
> On 2014-03-07, at 12:08 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
>> Next line is not needed, I think it was there because some time ago proj_out() returned basic Node* type. as_Proj() is simple cast and assert. And that is already done in proj_out() method now.
>> other_proj = other_proj -> as_Proj();
>> Also don't use spaces around '->' in your changes.
>> On 3/7/14 6:50 AM, David Chase wrote:
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8028037
>>> Fix: http://cr.openjdk.java.net/~drchase/8028037/webrev.00/
>>> Testing: local jtreg.
>>> The fix addresses half of the bug, inserting a null check to keep Parfait happy. The logic to ensure that the null cannot happen is a little convoluted and split across two places.
>>> The other half of the bug is addressed (separately, by other people) with an addition to the Parfait configuration files so that report_vm_error is treated as an exit (which it is except for certain cases of debugging).
More information about the hotspot-compiler-dev