RFR(L): 8032410: compiler/uncommontrap/TestStackBangRbp.java times out on Solaris-Sparc V9
roland.westrelin at oracle.com
Mon Mar 17 18:23:53 UTC 2014
> Mikael matched code in interpreter in AbstractInterpreterGenerator::bang_stack_shadow_pages(). This way we consistently touching the same number of pages.
> What I want to avoid is 8026775 situation when a middle page is not touched. My main concern now is that you changed the page where banging *starts* even so the variable is named bang_end:
> // This is how far the previous frame's stack banging extended.
> const int bang_end_safe = bang_end;
> But after 8026775 change (<=StackShadowPages) your changes seems right since StackShadowPages*page_size is already touched.
> You may be touching +1 page but as we discussed above with StackYellowPages >=2 it should be fine.
Here is a new webrev:
that should take all comments into account. In particular as suggested by Goetz I got rid of the templates. The native wrappers now bang to StackShadowPages+1.
More information about the hotspot-compiler-dev