RFR(L) 8001532: C2 node files refactoring

Christian Thalinger christian.thalinger at oracle.com
Mon Mar 17 18:26:35 UTC 2014

Did you try to build on Linux and/or OS X without pre-compiled headers?


Did these changes accidentally slip in?


+class BinaryNode : public Node {

Not sure if this is a good place for BinaryNode.  matcher.hpp shouldn’t contain any nodes.

I don’t want to put the burden upon you but it would be *really* nice if we could unify class and method comments.  Preferably Doxygen format.

Otherwise this looks good.

On Mar 17, 2014, at 6:51 AM, Morris Meyer <morris.meyer at oracle.com> wrote:

> Folks,
> Could I get a review for 8001532 - refactoring the old connode file in the C2 source tree?
> I've broken connode into bitsnode, castnode, constnode, convertnode, movenode, narrownode, optonode and threadnode.
> This change has been through JPRT.
>        --morris meyer
> JBS - https://bugs.openjdk.java.net/browse/JDK-8001532
> WEBREV - http://cr.openjdk.java.net/~morris/8001532.01

More information about the hotspot-compiler-dev mailing list