RFR(L) 8001532: C2 node files refactoring
vladimir.kozlov at oracle.com
Mon Mar 17 22:20:27 UTC 2014
File names usually match base class name of ideal nodes. Please change:
constnode back to connode
bitsnode --> countbitsnode
narrownode --> narrowptrnode
optonode --> opaquenode
PartialSubtypeCheckNode class should be in new intrinsicnode file
together with other similar classes from memnode files: StrIntrinsicNode
and related, EncodeISOArrayNode.
ThreadLocalNode can be kept in connode because it is kind of a constant
Put BinaryNode into movenode.hpp since it references cmove nodes.
constnode.hpp is included into callnode.hpp so you don't need to include
it into files which have callnode.hpp included. Yes, we had it before
but you are cleaning the code.
On 3/17/14 6:51 AM, Morris Meyer wrote:
> Could I get a review for 8001532 - refactoring the old connode file in
> the C2 source tree?
> I've broken connode into bitsnode, castnode, constnode, convertnode,
> movenode, narrownode, optonode and threadnode.
> This change has been through JPRT.
> --morris meyer
> JBS - https://bugs.openjdk.java.net/browse/JDK-8001532
> WEBREV - http://cr.openjdk.java.net/~morris/8001532.01
More information about the hotspot-compiler-dev