RFR(L) 8001532: C2 node files refactoring

Morris Meyer morris.meyer at oracle.com
Tue Mar 18 15:57:54 UTC 2014


Thanks for the review. Comments inline.

On 3/17/14, 2:26 PM, Christian Thalinger wrote:
> Did you try to build on Linux and/or OS X without pre-compiled headers?
Yes - Tried on the Mac without pre-compiled headers.
> src/share/vm/memory/allocation.hpp:
> Did these changes accidentally slip in?
Yes - purged.
> src/share/vm/opto/matcher.hpp:
> +class BinaryNode : public Node {
> Not sure if this is a good place for BinaryNode.  matcher.hpp shouldn’t contain any nodes.
Moved this to movenode.
> I don’t want to put the burden upon you but it would be *really* nice if we could unify class and method comments.  Preferably Doxygen format.
Added doxygen comments to convertnode.hpp. Maybe adding Doxygen comments 
could be a starter task?
> Otherwise this looks good.

JPRT - hotspotwest - 2014-03-18-144255.mameyer.8001532
WEBREV - http://cr.openjdk.java.net/~morris/8001532.02

> On Mar 17, 2014, at 6:51 AM, Morris Meyer<morris.meyer at oracle.com>  wrote:
>> Folks,
>> Could I get a review for 8001532 - refactoring the old connode file in the C2 source tree?
>> I've broken connode into bitsnode, castnode, constnode, convertnode, movenode, narrownode, optonode and threadnode.
>> This change has been through JPRT.
>>         --morris meyer
>> JBS -https://bugs.openjdk.java.net/browse/JDK-8001532
>> WEBREV -http://cr.openjdk.java.net/~morris/8001532.01

More information about the hotspot-compiler-dev mailing list