RFR (L): 8035857: Add tests to verify correctness of operations with BMI1 and LZCNT instructions

Filipp Zhinkin filipp.zhinkin at oracle.com
Fri Mar 21 08:04:44 UTC 2014

Hi Igor,

thank you for looking at it.

On 03/21/2014 12:34 AM, Igor Veresov wrote:
> Asserts.java:
>   389      * @param msg Adescription of the assumption.
> Typo: space missing
I'll fix it.

> Otherwise seems good.
> igor
> On Mar 20, 2014, at 12:12 PM, Filipp Zhinkin <filipp.zhinkin at oracle.com> wrote:
>> Hi all,
>> I'd like to add new tests that verifies correctness of code that
>> use BMI1 and LZCNT instructions.
>> Tests executed in two JVM processes - one started in Xint mode
>> and other in Xcomp. Results obtained from these processes compared
>> and tests pass only if results are equal.
>> Despite the fact that there is a test on
>> {Integer,Long}::{numberOfLeadingZeros,numberOfTrailingZeros} intrinsics
>> (compiler/6823354/Test6823354.java), I've added test cases to cover it
>> too in order to verify that everything works fine with explicitly specified
>> +UseCountTrailingZerosInstruction and +UseCountLeadingZerosInstruction.
>> Test execution will be skipped if CPU on test box does not support
>> required features. In order to check supported features new WB method
>> was added. WhiteBox::getCPUFeatures() return VM_Version::cpu_features()
>> string, which is parsed in order to gather CPU features.
>> Webrev: http://cr.openjdk.java.net/~iignatyev/fzhinkin/8035857/webrev.00/
>> Testing: JPRT, manual, automated.
>> Thanks,
>> Filipp.

More information about the hotspot-compiler-dev mailing list