RFR(S): 8005079: fix LogCompilation for incremental inlining
roland.westrelin at oracle.com
Fri Mar 21 15:34:38 UTC 2014
> It is good.
Thanks for the review.
> One thing you may need to change is C->log_inline_id((jlong)this).
> Address is not good id when you look on log file and it could be the same between compilations.
> I think some combination of compile_id<<shift+(adjustment for OSR when CICountOSR=true)+(unique node number at time when cg was created or other sequential number).
I don’t understand why it matters. The id is only used within a single compilation by the LogCompilation tool to correctly match a call site at which we stopped inlining with a call site at which we start to inline again later on.
> On 3/21/14 2:04 AM, Roland Westrelin wrote:
>>> In order for equals to be correct you have to do an instanceof check.
More information about the hotspot-compiler-dev