[9] RFR(S): 8029343: CodeCache::allocate increments '_number_of_blobs' even if allocation fails.

Tobias Hartmann tobias.hartmann at oracle.com
Tue May 6 07:27:08 UTC 2014


please review the following patch for bug 8029343.

(1) CodeCache::allocate(...) increments _number_of_blobs before the 
actual allocation is performed. In case the allocation fails the counter 
is set to a wrong value.
(2) The guarantee(size >= 0, ...) is incorrect. Calling 
CodeCache::allocate(...) with size = 0 leads to a segmentation fault. 
Further, a guarantee is too strong here. We can simply return NULL at 
runtime if the size is <= 0.
Bug: https://bugs.openjdk.java.net/browse/JDK-8029343

(1) The increment is moved after the allocation.
(2) An assert is used instead of the guarantee and NULL is returned if 
size <= 0.
Webrev: http://cr.openjdk.java.net/~anoll/8029343/webrev.00/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-compiler-dev/attachments/20140506/f53752c8/attachment.html>

More information about the hotspot-compiler-dev mailing list