Request for review: JDK-8032970: stack size check methods for WhiteBox API
vladimir.kozlov at oracle.com
Wed May 14 18:56:33 UTC 2014
Thank you explanation, Kirill
WBStackSize.java: please, use more descriptive names for variables:
fss < tss * 0.9 || fss > tss
You may want to run WBStackSize with -Xint. With compiled code stack
consumption is different. jtreg test could be run with -Xcomp by harness
(during Nightly), please, test such configurations.
On 5/14/14 9:29 AM, Kirill Shirokov wrote:
> Thanks to all reviewers!
> Could I ask to reivew the fixed patch:
> Bug report:
> The new functions will be used in the existing JSR292 tests -- we see a
> lot of failures due to StackOverflowError.
> Best regards,
> On 02/04/2014 10:03 PM, Vladimir Kozlov wrote:
>> You should include link to the bug report and add more explanation
>> what this changes for. Will new functions be used in new or existing
>> jsr292 tests?
>> test/testlibrary_tests directory is used for classes used by other
>> tests. I think you need to move new test WBStackSize.java into
>> test/runtime directory.
>> On 2/4/14 6:43 AM, Kirill Shirokov wrote:
>>> Please review following webrev, which adds stack size checking methods
>>> to WhiteBox API:
>>> Thank you,
More information about the hotspot-compiler-dev