[9] RFR(L): 8034812: remove IDX_INIT macro hack in Node class

Vladimir Kozlov vladimir.kozlov at oracle.com
Thu May 15 21:27:32 UTC 2014


Changes are fine but I am concern about compilation speed.
Please, test compilation performance (-XX:+TimeCompiler) on x86 and 
sparc. You need to build optimized VM for that to exclude assert but 
keep statistic code. I would suggest to run one of nashorn octane 
benchmarks with -Xcomp -XX:-TieredCompilation to get compilation with 
big graphs.


On 5/15/14 11:53 AM, Tobias Hartmann wrote:
> Hi,
> please review the following patch that removes the IDX_INIT macro used
> by Node::Node(...) to retrieve the Compile object and replaces it by a
> call to Compile::current(). The Node constructor, new operator and all
> calls to it are adapted accordingly.
> Bug: https://bugs.openjdk.java.net/browse/JDK-8034812
> Webrev: http://cr.openjdk.java.net/~anoll/8034812/webrev.00/
> Tested with JPRT.
> Thanks,
> Tobias

More information about the hotspot-compiler-dev mailing list