RFR(L): 8034812: remove IDX_INIT macro hack in Node class
tobias.hartmann at oracle.com
Fri May 16 08:28:57 UTC 2014
Vladimir, Goetz, thanks for the feedback.
On 16.05.2014 10:01, Lindenmaier, Goetz wrote:
> Hi Tobias,
> thanks for editing ppc! I'll test the change and also supply a fix
> for the issue mentioned by Igor. Is it ok if I just send a patch with
> the diffs?
I fixed it, please find the new webrev at
> Best regards,
> -----Original Message-----
> From: hotspot-compiler-dev [mailto:hotspot-compiler-dev-bounces at openjdk.java.net] On Behalf Of Igor Veresov
> Sent: Donnerstag, 15. Mai 2014 21:05
> To: Tobias Hartmann
> Cc: hotspot-compiler-dev at openjdk.java.net
> Subject: Re:  RFR(L): 8034812: remove IDX_INIT macro hack in Node class
> In ppc.ad you did s/new (C)//g instead of s/new (C)/new/g.
> Otherwise seems alright.
Thank you! I wonder why this was not caught by JPRT.
> On May 15, 2014, at 11:53 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:
>> please review the following patch that removes the IDX_INIT macro used by Node::Node(...) to retrieve the Compile object and replaces it by a call to Compile::current(). The Node constructor, new operator and all calls to it are adapted accordingly.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8034812
>> Webrev: http://cr.openjdk.java.net/~anoll/8034812/webrev.00/
>> Tested with JPRT.
More information about the hotspot-compiler-dev