RFR(L): 8034812: remove IDX_INIT macro hack in Node class
christian.thalinger at oracle.com
Fri May 16 15:57:11 UTC 2014
On May 15, 2014, at 2:27 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> Changes are fine but I am concern about compilation speed.
> Please, test compilation performance (-XX:+TimeCompiler) on x86 and sparc. You need to build optimized VM for that to exclude assert but keep statistic code. I would suggest to run one of nashorn octane benchmarks with -Xcomp -XX:-TieredCompilation to get compilation with big graphs.
Before I filed the bug I tested compilation speed on a SPARC T4 and couldn’t notice any performance difference. Anyway, this is just one data point. Tobias, please do test on other platforms and machines as well.
> On 5/15/14 11:53 AM, Tobias Hartmann wrote:
>> please review the following patch that removes the IDX_INIT macro used
>> by Node::Node(...) to retrieve the Compile object and replaces it by a
>> call to Compile::current(). The Node constructor, new operator and all
>> calls to it are adapted accordingly.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8034812
>> Webrev: http://cr.openjdk.java.net/~anoll/8034812/webrev.00/
>> Tested with JPRT.
More information about the hotspot-compiler-dev