RFR(L): 8034812: remove IDX_INIT macro hack in Node class
tobias.hartmann at oracle.com
Wed May 28 07:42:26 UTC 2014
as you suggested, I tested the fix both on x86 and sparc by running
Octane with -Xcomp and -XX:-TieredCompilation and measured the
compilation speed. There is no regression. I attached the results  to
I also executed SPECjbb2005, SPECjbb2013 and SPECjvm2008-Compiler on
Perf-Aurora to make sure that there is no performance regression. I
posted the link in the bug description.
-- x86_64, Solaris --
Score: 150.8 (+- 2.1)
Compilation speed: 31548.7 bytes/s (+- 247.67)
Score: 151.1 (+- 1.86)
Compilaion speed: 31878.5 bytes/s (+- 195.88)
-- Sparc, Solaris --
Score: 17.46 (+- 0.11)
Compilation speed: 4342.5 (+- 55.32)
Score: 17.4 (+- 0.13)
Compilation speed: 4349.5 (+- 69.66)
The numbers in brackets show the 95% confidence interval.
On 15.05.2014 23:27, Vladimir Kozlov wrote:
> Changes are fine but I am concern about compilation speed.
> Please, test compilation performance (-XX:+TimeCompiler) on x86 and
> sparc. You need to build optimized VM for that to exclude assert but
> keep statistic code. I would suggest to run one of nashorn octane
> benchmarks with -Xcomp -XX:-TieredCompilation to get compilation with
> big graphs.
> On 5/15/14 11:53 AM, Tobias Hartmann wrote:
>> please review the following patch that removes the IDX_INIT macro used
>> by Node::Node(...) to retrieve the Compile object and replaces it by a
>> call to Compile::current(). The Node constructor, new operator and all
>> calls to it are adapted accordingly.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8034812
>> Webrev: http://cr.openjdk.java.net/~anoll/8034812/webrev.00/
>> Tested with JPRT.
More information about the hotspot-compiler-dev