RFR (XS): 8043207: Add const to Address argument for Assembler::swap

Mikael Vidstedt mikael.vidstedt at oracle.com
Thu May 29 20:12:03 UTC 2014

Since this is a build problem the testing pretty much comes with 
building on the relevant platforms, which all pass with the fix in place.


On 2014-05-29 13:04, David Chase wrote:
> Any testing?  (and except for that issue, I, a non-Reviewer, approve)
> On 2014-05-28, at 12:17 PM, Mikael Vidstedt <mikael.vidstedt at oracle.com> wrote:
>> Please review the following fix which changes one of the Assembler::swap methods to take a *const* Address argument instead of a non-const. Some of the usages of the swap method pass a const argument, and when compiling with gcc the const-ness mismatch means the method cannot be resolved which in turn means a compilation error. This is for jdk7u (only) - the relevant code has been rewritten in jdk8+ to no longer have this problem.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8043207
>> Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8043207/webrev.00/webrev/
>> Thanks,
>> Mikael

More information about the hotspot-compiler-dev mailing list