RFR(S): 8060479: [TESTBUG] compiler/codecache/CheckSegmentedCodeCache.java test fails with product build
vladimir.kozlov at oracle.com
Sat Oct 18 00:46:24 UTC 2014
WB get*Flag interface should be fixed! The constant value of develop
flags are available in product VM. You need to call Flag::find_flag()
with return_flag = true. WB should not use default CommandLineFlags
class methods but define its own or extend CommandLineFlags's methods.
Igor I. should comment on this since he is author of "new WB API ::
On 10/17/14 3:18 AM, Tobias Hartmann wrote:
> Hi Vladimir,
> On 17.10.2014 10:47, Vladimir Kozlov wrote:
>> CodeCacheMinimumUseSpace is different for Zero. There is WB API which returns
>> options value getUintxVMFlag() you can use to calculate value minSize.
> Yes, but the flag is only available in debug builds. See 'Flag::find_flag':
> 525 // Don't report notproduct and develop flags in product builds.
> Calling getUintxVMFlag() throws a java.lang.NullPointerException with product
> builds. One solution would be to only perform this check for debug builds where
> we are able to compute the size. What do you think?
>> 8046809 changes will change min_code_cache_size value again (removes
>> CodeCacheMinimumFreeSpace). Let Albert know to modify this test again.
> I will do so.
>> On 10/17/14 12:00 AM, Tobias Hartmann wrote:
>>> Can I get another review for this?
>>> On 15.10.2014 16:19, Tobias Hartmann wrote:
>>>> please review the following patch.
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8060479
>>>> Webrev: http://cr.openjdk.java.net/~thartmann/8060479/webrev.00/
>>>> The test CheckSegmentedCodeCache assumes that VM startup always fails with a
>>>> ReservedCodeCacheSize of 1700K. This is not true for product builds (see
>>>> 'min_code_cache_size' in 'CodeCache::initialize_heaps()').
>>>> Check for debug build and adjust minimum code cache size accordingly.
>>>> Failing test on JPRT.
More information about the hotspot-compiler-dev