[9] RFR(L): 8046809: vm/mlvm/meth/stress/compiler/deoptimize CodeCache is full.

John Rose john.r.rose at oracle.com
Tue Oct 21 20:00:33 UTC 2014

On Oct 16, 2014, at 1:33 AM, Albert Noll <albert.noll at oracle.com> wrote:

> Can I have a second review?


Question:  Can you say why "handle_full_code_cache" doesn't need to be called so much anymore?
It seems a non-trivial issue since you were able to delete it from so many places, but not all.
I suggest adding a comment to the header of handle_full_code_cache to guide future coders where the calls must be put.

A couple of typos:

  + "Start aggressive sweeping if X[%] of the code cache are free."   \
s/are/is/ (percentage of singular is singular as in, 5% of code cache is full, etc.)

 + init_log_sweeer
s/sweeer/sweeper/; IMO should actually be "init_records", "init_log", or "init_sweeper_log".
(Sweeering is not done in polite company!)

I like the cleanups.  Lots of tidying, code deletion, and factoring.
You have taken a hard part of the JVM and made it incrementally simpler and nicer to work with.

— John

More information about the hotspot-compiler-dev mailing list